Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -621,11 +621,7 @@ private <T> Coder<T> getCoderFromTypeDescriptor(
} else if (type instanceof WildcardType) {
// No coder for an unknown generic type.
throw new CannotProvideCoderException(
String.format(
"Cannot provide a coder for type variable %s"
+ " (declared by %s) because the actual type is unknown due to erasure.",
type, ((TypeVariable<?>) type).getGenericDeclaration()),
ReasonCode.TYPE_ERASURE);
String.format("Cannot provide a coder for wildcard type %s.", type), ReasonCode.UNKNOWN);
} else {
throw new RuntimeException("Internal error: unexpected kind of Type: " + type);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.io.Serializable;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Type;
import java.util.Collections;
import java.util.List;
Expand Down Expand Up @@ -149,6 +150,21 @@ public void testParameterizedDefaultCoderUnknown() throws Exception {
registry.getCoder(listUnknownToken);
}

@Test
public void testParameterizedWildcardTypeIsUnknown() throws Exception {
CoderRegistry registry = CoderRegistry.createDefault();
TypeDescriptor<List<? extends MyValue>> wildcardUnknownToken =
new TypeDescriptor<List<? extends MyValue>>() {};

thrown.expect(CannotProvideCoderException.class);
thrown.expectMessage(
String.format(
"Cannot provide coder for parameterized type %s: Cannot provide a coder for wildcard type %s.",
wildcardUnknownToken,
((ParameterizedType) wildcardUnknownToken.getType()).getActualTypeArguments()[0]));
registry.getCoder(wildcardUnknownToken);
}

@Test
public void testTypeParameterInferenceForward() throws Exception {
CoderRegistry registry = CoderRegistry.createDefault();
Expand Down