[BEAM-4798] Fix IndexOutOfBoundsException in Flink runner#6177
Merged
tweise merged 2 commits intoapache:masterfrom Aug 10, 2018
Merged
[BEAM-4798] Fix IndexOutOfBoundsException in Flink runner#6177tweise merged 2 commits intoapache:masterfrom
tweise merged 2 commits intoapache:masterfrom
Conversation
aljoscha
force-pushed
the
finish-pr-5996-fix-source-splits
branch
from
3dc7cb9 to
fbf7dcd
Compare
Contributor
Author
|
Run Flink ValidatesRunner |
Contributor
Author
|
retest this please |
Contributor
aromanenko-dev
left a comment
aromanenko-dev
left a comment
There was a problem hiding this comment.
Thank you for fixing this test, I just added one minor note.
| actualNumSplits = desiredNumSplits; | ||
| } else { | ||
| actualNumSplits = fixedNumSplits; | ||
| } |
Contributor
There was a problem hiding this comment.
I believe, this can be one line, like int actualNumSplits = (fixedNumSplits == -1) ? desiredNumSplits : fixedNumSplits
aljoscha
force-pushed
the
finish-pr-5996-fix-source-splits
branch
from
c8c55a8 to
b1fa8d1
Compare
Contributor
Author
|
retest this please |
aljoscha
force-pushed
the
finish-pr-5996-fix-source-splits
branch
from
1344d8a to
24d5bbe
Compare
Contributor
Author
|
retest this please |
than number of IO readers
Before, the test did not try running the source with different simulated subtask indices, i.e. we were not exercising many of the code paths. This also fixes a bunch of concurrency issues in the source and test that came up while extending it for simulating running at different subtask indices.
aljoscha
force-pushed
the
finish-pr-5996-fix-source-splits
branch
from
24d5bbe to
45a3efc
Compare
Contributor
Author
|
Run Flink ValidatesRunner |
Contributor
|
Thank you @aljoscha for fixing the tests issue, LGTM |
Contributor
Author
|
@tweise Could you maybe have a look? |
tweise
approved these changes
Aug 10, 2018
Contributor
Author
|
thanks @tweise ! And thanks @aromanenko-dev for discovering and fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an addition on top of #5996 that fixes the test so that it would have caught the bug that @aromanenko-dev fixed in #5996.
CC @aromanenko-dev
@tweise Maybe this is relevant to your work on portability but I don't think so. Neverthelesse, doesn't hurt to take a look. 😅
Post-Commit Tests Status (on master branch)