[BEAM-4846] Fixing updateOfflineRepository task. #6196
Merged
pabloem merged 2 commits intoapache:masterfrom Aug 9, 2018
Merged
[BEAM-4846] Fixing updateOfflineRepository task. #6196pabloem merged 2 commits intoapache:masterfrom
pabloem merged 2 commits intoapache:masterfrom
Conversation
Member
Author
|
Run Java PreCommit |
pabloem
changed the title
Member
Author
|
Run Java PreCommit |
Member
Author
|
Retest this please |
Member
Author
|
Run Java PreCommit |
Member
Author
|
Run Java PreCommit |
Member
Author
|
I only had to run PreCommit 8 times : D |
lukecwik
approved these changes
Aug 9, 2018
Member
lukecwik
left a comment
lukecwik
left a comment
There was a problem hiding this comment.
I made some comment changes, hopefully not breaking the spotless configuration.
If I did, feel free to correct it and merge.
Member
|
Sweet, didn't think the fix was going to be this easy. Any clue as to why it wasn't working? |
Member
Author
|
No clue : ) - but this is good enough to run |
Member
|
Well, it looks like the spotless check for buildSrc passed so feel free to merge this as I only made comment changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should still be run with --no-parallel
r: @lukecwik