Merged
Conversation
Contributor
Author
|
run java postcommit |
3 similar comments
Contributor
Author
|
run java postcommit |
Contributor
Author
|
run java postcommit |
Contributor
Author
|
run java postcommit |
Contributor
Author
apilloud
reviewed
Aug 13, 2018
|
|
||
| // wait one minute to allow subscription creation. | ||
| Thread.sleep(60 * 1000); | ||
| eventsTopic.checkIfAnySubscriptionExists(project, Duration.standardMinutes(1)); |
Member
There was a problem hiding this comment.
It would be more correct to pull project out of the pipeline you're using here, rather then from TestPipeline globally. I believe pipeline.getOptions().as(GcpOptions.class).getProject() should work.
Contributor
Author
There was a problem hiding this comment.
The project option is set for TestPipelineOption from build.gradle so it's supposed to have the same value.
But yes, I agree that I should get project from existing pipeline.
amaliujia
force-pushed
the
rui_wang-improve_tests
branch
from
84a7931 to
4acbd75
Compare
Contributor
Author
|
run java postcommit |
Member
|
LGTM! Thanks! |
akedin
approved these changes
Aug 14, 2018
|
|
||
| // wait one minute to allow subscription creation. | ||
| Thread.sleep(60 * 1000); | ||
| eventsTopic.checkIfAnySubscriptionExists( |
amaliujia
force-pushed
the
rui_wang-improve_tests
branch
from
4acbd75 to
c77eeff
Compare
Contributor
Author
|
run java postcommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve PubsubIT by removing Thread.sleep and using
eventsTopic.checkIfAnySubscriptionExists.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)