-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-4176] move some artifact-staging logs from info to debug #6225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM |
|
Finally coming back to this; I tried adding an SDK-side log as you suggested, but it feels equivalently spammy to me at first glance: do you think it's important to INFO-log every artifact? I'd have said these should be DEBUGs on both ends perhaps two INFOs saying "staging X artifacts" / "staged X artifacts"? |
|
Yes, they seem to be a bit spammy. |
|
I suggest you follow the same pattern like Dataflow has been doing: |
angoenka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ryan.
LGTM
Please squash the commits
|
several tests failed that I don't think are related to my changes here:
perhaps the hadoop and AWS modules were conflicting about binding the same port? I'm not sure what happened to the elasticsearch test |
|
Run Java PreCommit |

these were generating a somewhat-inordinate-seeming amount of log-spam (cf. example VR test output)
R: @angoenka
Post-Commit Tests Status (on master branch)