Skip to content

Allow custom server ID for publishing Java artifacts.#6230

Merged
tweise merged 2 commits intoapache:masterfrom
tweise:customArtifactDeploy
Aug 15, 2018
Merged

Allow custom server ID for publishing Java artifacts.#6230
tweise merged 2 commits intoapache:masterfrom
tweise:customArtifactDeploy

Conversation

@tweise
Copy link
Contributor

@tweise tweise commented Aug 15, 2018

Please add a meaningful description for your change here


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@pabloem
Copy link
Member

pabloem commented Aug 15, 2018

If I understand correctly, you can pass -PdistMgmtServerId=... and publish to your particular artifactory? If that's the case, then this LGTM

Also, I saw that you wanted to skip signing? perhaps we could add a -PnoSign flag, or allow the publish task to exist without -PisRelease.

@tweise
Copy link
Contributor Author

tweise commented Aug 15, 2018

@pabloem this is how I would run the command:
./gradlew :beam-runners-flink_2.11-job-server:publish -Ppublishing -PdistMgmtSnapshotsUrl=https://mycustomrepo/libs-snapshots -PdistMgmtServerId=snapshots --no-parallel --no-daemon

Looking at adding the -PnoSign flag now..

@tweise
Copy link
Contributor Author

tweise commented Aug 15, 2018

@lukecwik @pabloem PTAL

@pabloem
Copy link
Member

pabloem commented Aug 15, 2018

LGTM!

@tweise tweise merged commit 51f8a29 into apache:master Aug 15, 2018
@tweise tweise deleted the customArtifactDeploy branch August 15, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants