Skip to content

Adding autocomplete as an integration test. #6253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pabloem merged 3 commits into from
Aug 21, 2018
Merged

Adding autocomplete as an integration test. #6253

pabloem merged 3 commits into from
Aug 21, 2018

Conversation

@pabloem
Copy link
Member

@pabloem pabloem commented Aug 20, 2018 •
edited
Loading

Autocomplete exercises Combine (Top) functionality, so it's worth having.

@pabloem

This comment has been minimized.

Sign in to view
@pabloem
Copy link
Member Author

pabloem commented Aug 20, 2018

Run Python PostCommit

@pabloem
Copy link
Member Author

pabloem commented Aug 20, 2018

Run Python PostCommit

@pabloem
Copy link
Member Author

pabloem commented Aug 20, 2018

Here's an example job: https://pantheon.corp.google.com/dataflow/jobsDetail/locations/us-central1/jobs/2018-08-20_15_24_11-12916912687547781957?project=apache-beam-testing

@pabloem
Copy link
Member Author

pabloem commented Aug 20, 2018

r: @boyuanzz
This adds Autocomplete as a full e2e test for Python.

boyuanzz
boyuanzz approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@boyuanzz boyuanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pabloem pabloem merged commit 592203e into apache:master Aug 21, 2018
@pabloem pabloem deleted the autocomplete-it branch August 21, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boyuanzz boyuanzz boyuanzz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pabloem @boyuanzz @pab-goog