[BEAM-5378] - Update minimal_wordcount.go to reflect documentation

[ptomasroos]

In order to be able to run minimal_wordcount on both direct and dataflow I updated the example to reflect that.

@lostluck @herohde

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Samza	Spark
Go		---	---	---	---	---	---
Java
Python		---		---	---	---	---

[lostluck]

My understanding is that the minimal_wordcount isn't intended to be run on any distributed runner, or serve as a minimal production pipeline.

It's to serve as a toy example to what a beam pipeline looks like, and introduce the model concepts, which can be learned separately. This may not be adequately documented at present. I agree that it doesn't serve as the best tutorial/introduction as of yet. Someone would need to spend the time to improve this.

That said, the other wordcount examples are closer to production style pipelines, so these kinds of updates would be reasonable for them.

[herohde]

Yeah -- minimal_wordcount is written to closely match the Java version and progression of WordCount pipelnes. It's not a good model for pipelines due the the simplifications it makes.

[lostluck]

@ptomasroos Specifically, this guide:
https://beam.apache.org/get-started/wordcount-example/

Edit: Though it looks like the described changed a bit, without the code changing to match, and there's now Go code in those docs! That would probably be a good resolution to this, for these to match properly.

[ptomasroos]

Ok. I've checked through the Python source-code on what it does, and its aligned with my first changes. I've now updated the documentation of the website as well to reflect this.

[lostluck]

LGTM

Thanks for your patience Tomas!

I have one question re: if the master repo is now officially where the site documentation needs to be updated. Another recent change had to be applied to the other repo. The Code change LGTM, so we can merge once we hear from Melissa.

[lostluck]

FYI, I don't think the site uses this copy in master just yet.

@melap Is that still true? Does this change need to go into the old site repo still?

[melap]

Correct, changes to website markdown still need to be done in beam-site until the migration is complete

[stale]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

[stale]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.