[BEAM-2887] Remove special FnApi version of wordcount. #6504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "standard" wordcount now runs on FnApi, use that for integration testing.
Contributor
Author
|
Run Python PostCommit |
Contributor
Author
|
R: @aaltay |
aaltay
reviewed
Oct 2, 2018
| def test_wordcount_fnapi_it(self): | ||
| self._run_wordcount_it(experiment='beam_fn_api') | ||
|
|
||
| def _run_wordcount_it(self, **opts): |
Member
There was a problem hiding this comment.
Where is opts is used? I am not sure how experiment is passed down.
Contributor
Author
There was a problem hiding this comment.
Oh, yes, this was completely lost in the refactor. Thanks for catching this!
Contributor
Author
|
Run Python PostCommit |
Contributor
Author
|
Jeknins: Run Python PostCommit |
Contributor
Author
|
Jenkins: Run Python PostCommit |
Contributor
Author
|
Run Python PostCommit |
Contributor
Author
|
The postcommit error seems to be for the unrelated test_user_score_it. Trying again. Run Python PostCommit |
Contributor
Author
|
Run Python PostCommit |
1 similar comment
Contributor
Author
|
Run Python PostCommit |
Contributor
Author
|
Run Python Postcommit |
aaltay
approved these changes
Oct 8, 2018
Member
aaltay
left a comment
aaltay
left a comment
There was a problem hiding this comment.
LGTM. Please self merge when after tests pass.
Contributor
Author
|
Thanks. This test is passing regularly, but I'd really like to see an all-clean run before merging. |
Contributor
Author
|
Run Python Postcommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "standard" wordcount now runs on FnApi, use that for integration testing.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)