[BEAM-5626] Unskip hadoopfilesystem_test which is already passing in Python 3.#6628
Merged
manuzhang merged 1 commit intoapache:masterfrom Oct 11, 2018
Merged
[BEAM-5626] Unskip hadoopfilesystem_test which is already passing in Python 3.#6628manuzhang merged 1 commit intoapache:masterfrom
manuzhang merged 1 commit intoapache:masterfrom
Conversation
tvalentyn
force-pushed
the
patch-23
branch
6 times, most recently
from
ebd46f1 to
13fcbad
Compare
Contributor
Author
|
retest this please |
tvalentyn
changed the title
Member
|
Isn't BEAM-5626 already solved ? It seems this PR also skips some tests. Could you please give a more meaningful description ? |
Contributor
Author
|
BEAM-5626 is solved, that's exactly why I would like to add hadoopfilesystem_test to the test suite. |
Contributor
Author
|
It makes more sense to split commits into their own PRs. |
tvalentyn
changed the title
Member
|
LGTM |
Contributor
Author
|
Thanks for review & merge, @manuzhang! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hadoopfilesystem_test to Python 3 test suite. It was fixed in #6587.
cc: @Fematich @Juta @manuzhang @splovyt
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)