[BEAM-5744] Cherrypick PR 6686 to 2.8.0. release branch: #6688
Merged
aaltay merged 1 commit intoapache:release-2.8.0from Oct 18, 2018
Merged
[BEAM-5744] Cherrypick PR 6686 to 2.8.0. release branch: #6688aaltay merged 1 commit intoapache:release-2.8.0from
aaltay merged 1 commit intoapache:release-2.8.0from
Conversation
Contributor
Author
|
R: @aaltay |
robertwb
reviewed
Oct 15, 2018
| if target_batch_duration_secs and target_batch_duration_secs <= 0: | ||
| raise ValueError("target_batch_duration_secs (%s) must be positive" % ( | ||
| target_batch_duration_secs)) | ||
| if not (target_batch_overhead or target_batch_duration_secs): |
Contributor
There was a problem hiding this comment.
This line should be fine to keep.
Contributor
Author
There was a problem hiding this comment.
Yes we can keep this line. The roll-back PR was auto-generated and merged. This is a CP of the rollback to release branch. I don't it would make a difference on the release whether we roll this line forward or not, but we can roll it forward on master as a part of our Python 3 conversion efforts.
aaltay
approved these changes
Oct 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)