[BEAM-5791] Improve Python SDK progress counters.#6751
Merged
robertwb merged 1 commit intoapache:masterfrom Oct 22, 2018
Merged
[BEAM-5791] Improve Python SDK progress counters.#6751robertwb merged 1 commit intoapache:masterfrom
robertwb merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
R: @tvalentyn |
The returned metrics are supposed to count the elements consumed, which should be incremented after an element is produced, not before. Updated counters to correctly reflect this, which is important for tracking the rate of buffer consumption by runners Also, some runners (e.g. the Dataflow harness) don't set unique names on PTransforms, which was causing counters to be conflated. Now the counters use the ptransform_id if the unique name is not provided.
robertwb
force-pushed
the
progress-counters
branch
from
05995db to
ac59e68
Compare
tvalentyn
approved these changes
Oct 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The returned metrics are supposed to count the elements consumed, which should
be incremented after an element is produced, not before. Updated counters
to correctly reflect this, which is important for tracking the rate of buffer
consumption by runners
Also, some runners (e.g. the Dataflow harness) don't set unique names on
PTransforms, which was causing counters to be conflated. Now the counters
use the ptransform_id if the unique name is not provided.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)