Skip to content

Conversation

@mxm
Copy link
Contributor

@mxm mxm commented Oct 23, 2018

The check currently gets triggered on Jenkins but not when running on MacOS. It
is disabled at other places as well, so I'm assuming this is a valid fix for
now.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

The check currently gets triggered on Jenkins but not when running on MacOS. It
is disabled at other places as well, so I'm assuming this is a valid fix for
now.
@mxm mxm requested a review from robertwb October 23, 2018 09:50
@mxm
Copy link
Contributor Author

mxm commented Oct 23, 2018

CC @HuangLED @mwylde

@mxm
Copy link
Contributor Author

mxm commented Oct 23, 2018

Python PreCommit passes.

@robertwb
Copy link
Contributor

Yes, thanks.

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertwb robertwb merged commit f5ba855 into apache:master Oct 23, 2018
@HuangLED
Copy link
Contributor

Thanks a lot for the fix! :-)

@mxm mxm deleted the docs-fix branch October 24, 2018 12:54
@mxm
Copy link
Contributor Author

mxm commented Oct 24, 2018

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants