[BEAM-2717] Emit coders in generated protos. #6813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
charlesccychen
left a comment
charlesccychen
left a comment
There was a problem hiding this comment.
Thanks! Some minor comments.
sdks/python/apache_beam/pipeline.py
Outdated
| self.visit_transform(transform_node) | ||
|
|
||
| def visit_transform(self, transform_node): | ||
| if transform_node.transform and transform_node.transform.runner_api_requires_keyed_input(): |
Contributor
There was a problem hiding this comment.
Please fix line length and other presubmit issues.
robertwb
force-pushed
the
coder-in-protos
branch
from
d51a61e to
3aa2cdb
Compare
robertwb
commented
Oct 25, 2018
Contributor
Author
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
Thanks. Pushed fixes and keeping an eye on presubmits.
Contributor
Author
|
Resolved comments, precommits are happy. PTAL. |
Contributor
|
Thanks! This LGTM. |
robertwb
force-pushed
the
coder-in-protos
branch
from
10acddf to
d9b35a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)