Skip to content

[BEAM-5797] Ensure ExecutableStageDoFnOperator dispose is executed once#6828

Merged
tweise merged 1 commit intoapache:masterfrom
tweise:BEAM-5797.dispose
Oct 25, 2018
Merged

[BEAM-5797] Ensure ExecutableStageDoFnOperator dispose is executed once#6828
tweise merged 1 commit intoapache:masterfrom
tweise:BEAM-5797.dispose

Conversation

@tweise
Copy link
Contributor

@tweise tweise commented Oct 25, 2018


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@tweise
Copy link
Contributor Author

tweise commented Oct 25, 2018

CC: @mwylde

@tweise tweise requested a review from mxm October 25, 2018 00:28
Copy link
Contributor

@mxm mxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of unexpected that dispose can be called twice. Looked into the Flink code (StreamTask), and indeed it calls once without catching exceptions and, if exceptions occurred, another time where it catches exceptions and logs them.

@tweise tweise merged commit b5f7f74 into apache:master Oct 25, 2018
@tweise tweise deleted the BEAM-5797.dispose branch October 25, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants