Skip to content

[BEAM-5917] Update Flink to 1.5.5#6885

Merged
mxm merged 1 commit into
apache:masterfrom
mxm:flink-version
Nov 5, 2018
Merged

[BEAM-5917] Update Flink to 1.5.5#6885
mxm merged 1 commit into
apache:masterfrom
mxm:flink-version

Conversation

@mxm
Copy link
Copy Markdown
Contributor

@mxm mxm commented Oct 30, 2018

The force-shading module issue is strange but it doesn't seem to be published: https://repo.maven.apache.org/maven2/org/apache/flink/force-shading/

I've reported this on the Flink mailing list.

CC @angoenka @tweise

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

Copy link
Copy Markdown
Contributor

@tweise tweise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this on hold until the Flink issue is sorted out. I prefer generally that we wait until things are fully baked and we have done some more verification, the Flink release has been only out for a day..

@mxm
Copy link
Copy Markdown
Contributor Author

mxm commented Oct 31, 2018

IMHO updating to the latest bugfix release will give us only benefits. For minor releases I agree that it makes sense to wait a bit until it stabilizes.

The Flink issue is reported here: https://issues.apache.org/jira/browse/FLINK-10732

@tweise
Copy link
Copy Markdown
Contributor

tweise commented Oct 31, 2018

We can safely defer this change until after the Flink release is fixed, at which time it will be just a version number change with no other workarounds.

It would also be nice to run something on a Flink 1.5.5 cluster, if you had not already done that.

That can be done without any change in Beam (we are using 1.5.4 at Lyft currently).

@mxm
Copy link
Copy Markdown
Contributor Author

mxm commented Nov 5, 2018

The problem with the force-shading dependency has been resolved.

It would also be nice to run something on a Flink 1.5.5 cluster, if you had not already done that.

Typically, all hotfix versions of Flink are compatible with each other (in the absence of bugs). There are integration tests which run as part of this PR. In fact, I've already been using Flink 1.5.4 and 1.5.5 to run the Beam code based on Flink 1.5.3. I haven't experienced any problems. But let's run ValidatesRuner and PortableValidatesRunner.

@mxm
Copy link
Copy Markdown
Contributor Author

mxm commented Nov 5, 2018

Run Flink ValidatesRunner

@mxm
Copy link
Copy Markdown
Contributor Author

mxm commented Nov 5, 2018

Run Python Flink ValidatesRunner

@mxm
Copy link
Copy Markdown
Contributor Author

mxm commented Nov 5, 2018

Run Java Flink PortableValidatesRunner

@mxm
Copy link
Copy Markdown
Contributor Author

mxm commented Nov 5, 2018

All tests are passing. Also ran a manual cluster test.

@mxm mxm merged commit b3194d1 into apache:master Nov 5, 2018
@mxm mxm deleted the flink-version branch November 5, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants