[BEAM-5946] Upgrade google-apitools to 0.5.24#6915
Conversation
|
Run Python Dataflow ValidatesRunner |
|
Run Dataflow Python ValidatesRunner |
|
Thanks, please also update: https://github.com/apache/beam/blob/master/sdks/python/container/base_image_requirements.txt#L48 |
|
Run Python Dataflow ValidatesRunner |
85d4520 to
839e458
Compare
|
Run Python Dataflow ValidatesContainer |
|
Run Python Dataflow ValidatesRunner |
|
+R: @aaltay @tvalentyn |
|
Do you need to more the lower bound? |
|
Good catch. I think we should. The change that's important for Python 3 compatible starts at 0.5.23 (introduced in this commit). So I think we can move lower bound to 0.5.23 |
04add43 to
a421c05
Compare
|
Sounds good. Please remember to update dataflow container files as well. |
|
sure. will do. |
|
Please also file a JIRA and link to this PR, that way it will show up in 2.9.0 release notes. (And also add 2.9.0 as the fix version.) |
|
Done. Filed https://issues.apache.org/jira/browse/BEAM-5946. |
Upgrade google-apitools to latest version 0.5.24. which contains a important support for Python 3 incompatibility issue.
This upgrade helps to solve problem in BEAM-5788
@tvalentyn
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)