Skip to content

[BEAM-5946] Upgrade google-apitools to 0.5.24#6915

Merged
aaltay merged 1 commit intoapache:masterfrom
markflyhigh:py-upgrade-apitools
Nov 2, 2018
Merged

[BEAM-5946] Upgrade google-apitools to 0.5.24#6915
aaltay merged 1 commit intoapache:masterfrom
markflyhigh:py-upgrade-apitools

Conversation

@markflyhigh
Copy link
Contributor

@markflyhigh markflyhigh commented Nov 1, 2018

Upgrade google-apitools to latest version 0.5.24. which contains a important support for Python 3 incompatibility issue.

This upgrade helps to solve problem in BEAM-5788

@tvalentyn


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@tvalentyn
Copy link
Contributor

Run Python Dataflow ValidatesRunner

@tvalentyn
Copy link
Contributor

Run Dataflow Python ValidatesRunner

@tvalentyn
Copy link
Contributor

@tvalentyn
Copy link
Contributor

Run Python Dataflow ValidatesRunner

@markflyhigh
Copy link
Contributor Author

Run Python Dataflow ValidatesContainer

@markflyhigh
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@markflyhigh
Copy link
Contributor Author

+R: @aaltay @tvalentyn

@aaltay
Copy link
Member

aaltay commented Nov 1, 2018

Do you need to more the lower bound?

@markflyhigh
Copy link
Contributor Author

markflyhigh commented Nov 2, 2018

Good catch. I think we should. The change that's important for Python 3 compatible starts at 0.5.23 (introduced in this commit). So I think we can move lower bound to 0.5.23

@aaltay
Copy link
Member

aaltay commented Nov 2, 2018

Sounds good. Please remember to update dataflow container files as well.

@markflyhigh
Copy link
Contributor Author

markflyhigh commented Nov 2, 2018

sure. will do.

@aaltay
Copy link
Member

aaltay commented Nov 2, 2018

Please also file a JIRA and link to this PR, that way it will show up in 2.9.0 release notes. (And also add 2.9.0 as the fix version.)

@markflyhigh markflyhigh changed the title Upgrade google-apitools to 0.5.24 [BEAM-5946] Upgrade google-apitools to 0.5.24 Nov 2, 2018
@markflyhigh
Copy link
Contributor Author

@aaltay aaltay merged commit 94bdffe into apache:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants