[BEAM-4124] datamgr.go:Remove chunksize constraint#6948
Merged
Conversation
Go SDK harness was limited to elements of at most ~4MB with this check, but provided no means to increase it. The chunking is valuable for batching tiny elements over RPCs to improve throughput but is less meaningful for larger elements. The Go SDK shouldn't be dictating maximum element size, and let that be configurable by the FnAPI transport (eg. GRPC) to the runner harness instead. This should have an implicit ~2-4GB cap on element size.
Contributor
Author
aaltay
approved these changes
Nov 5, 2018
| // We can't fit this message into the buffer. We need to flush the buffer | ||
| if err := w.Flush(); err != nil { | ||
| return 0, err | ||
| return 0, fmt.Errorf("datamgr.go: error flushing buffer of length %d: %v", l, err) |
Member
There was a problem hiding this comment.
Curios, why not totally drop l and use len(w.buf) directly as an argument to Errorf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go SDK harness was limited to elements of at most ~4MB with this check, but provided no means to increase it. The chunking is valuable for batching tiny elements over RPCs to improve throughput but is less meaningful for larger elements.
The Go SDK shouldn't be dictating maximum element size, and let that be configurable by the FnAPI transport (eg. GRPC) to the runner harness instead. This should have an implicit ~2-4GB cap on element size.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)