Skip to content

[BEAM-5931]Revert "Revert "[BEAM-5299] Define max timestamp for global window in…#6990

Merged
mxm merged 1 commit intoapache:masterfrom
HuangLED:perfTest
Nov 9, 2018
Merged

[BEAM-5931]Revert "Revert "[BEAM-5299] Define max timestamp for global window in…#6990
mxm merged 1 commit intoapache:masterfrom
HuangLED:perfTest

Conversation

@HuangLED
Copy link
Contributor

@HuangLED HuangLED commented Nov 8, 2018

A revert of revert.

Original PR: #6381
Revert PR: #6899

more details see: https://issues.apache.org/jira/browse/BEAM-5931
PRs that fixes the failures: PR #6916 and PR#6966

This reverts commit 4e2ce75.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

… proto (#6381)""

This reverts commit 4e2ce75.

For testing purpose
@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 8, 2018

Run Java TextIO Performance Test

@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 8, 2018

Run Dataflow Runner Nexmark Tests

1 similar comment
@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 8, 2018

Run Dataflow Runner Nexmark Tests

@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 8, 2018

Run Java JdbcIO Performance Test

@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 8, 2018

Run Java MongoDBIO Performance Test

@HuangLED HuangLED changed the title Revert "Revert "[BEAM-5299] Define max timestamp for global window in… [BEAM-5931]Revert "Revert "[BEAM-5299] Define max timestamp for global window in… Nov 8, 2018
@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 8, 2018

Run Java PostCommit

@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 8, 2018

Run JavaPortabilityApi PreCommit

@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 9, 2018

@lgajowy @lukecwik @mxm

After the fixes, this PR should work.

@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 9, 2018

Run JavaPortabilityApi PreCommit

Copy link
Contributor

@mxm mxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up on this!

@mxm mxm merged commit 0f1f8f7 into apache:master Nov 9, 2018
@lgajowy
Copy link
Contributor

lgajowy commented Nov 9, 2018

Thanks, @HuangLED!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants