[BEAM-6052] Fixes bug in ElasticSearchIO for checkForErrors#7035
[BEAM-6052] Fixes bug in ElasticSearchIO for checkForErrors#7035Grypse wants to merge 48 commits intoapache:masterfrom Grypse:master
Conversation
This fixes 42984a8, which refactored the Dataflow runner build scripts to share a common buildAndPushDockerContainer task. However the task internally uses a dockerImageContainer variable which was not shared between projects and incorrectly duplicated: the generated name has an embedded timestamp, which will be re-evaluated per-project. This change refactors the projects to also share a single dockerImageContainer property.
echauchot
left a comment
There was a problem hiding this comment.
Thanks for that @Grypse !
- please add tests on the test suite for error parsing in ES2, ES5 and ES6 with partial update mode and full update mode
- comment for later, please rebase on master instead of making a merge commit of the master to your branch.
… metrics in Spark Web Interface.
…etrics in Spark Web Interface
+ Enable reading table name only + Tests for some NexmarkUtils' methods
[BEAM-4524] Use SHA256 for artifact validation
[Beam-6048] Fix for failure in beam-sdks-python:docs: Sphinx cannot find typing.G…
* [BEAM-6056] Publish gRPC 1.13.1 as a vendored dependency. For vendored artifacts, this change * adds license headers and properties related to our project to the pom.xml * includes the pom.xml and pom.properties in the jar * adds support for signing
[BEAM-5788] Update Dataflow API protocol buffers
|
@Grypse as I wrote above, you need to rebase your branch on master and not use merge. Right now your PR pushes commits that are already on master. Please re-make your branch: |
|
OK,
It's my first work with open source community. Can u teach me how to do it?
Thanks!
…On Tue, Nov 20, 2018 at 5:54 PM Etienne Chauchot ***@***.***> wrote:
@Grypse <https://github.com/Grypse> as I wrote above, you need to rebase
your branch on master and not use merge. Right now your PR pushes commits
that are already on master. Please re-make your branch:
checkout master
pull --rebase
checkout -b new-branch
and cherry pick your 2 commits on the new branch.
Please also add the tests that I was referring to above.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7035 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AI7sPV-asKY6PJLz9ucQHWnEfugPeH0Lks5uw9FlgaJpZM4YdfE9>
.
|
|
|
closing because replaced by #7206 |
@timrobertson100 @echauchot
The checkFor Errors method can not parse the update response before. So i just add the judge logical for partial update, it's a minor bug fix.
The general update response looks like this below:
So, we need to judge update for update path of jsonnode.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)