[BEAM-383] BigQueryIO update sink to shard into multiple write jobs#707
Closed
ianzhou1 wants to merge 7 commits intoapache:masterfrom
ianzhou1:BigQueryBranch
Closed
[BEAM-383] BigQueryIO update sink to shard into multiple write jobs#707ianzhou1 wants to merge 7 commits intoapache:masterfrom ianzhou1:BigQueryBranch
ianzhou1 wants to merge 7 commits intoapache:masterfrom
ianzhou1:BigQueryBranch
Conversation
Contributor
Author
|
R: @dhalperi |
| * | ||
| * <p> the RPC for at most {@code MAX_RPC_ATTEMPTS} times until it succeeds. | ||
| * | ||
| * @throws IOException if it exceeds max RPC . |
Contributor
There was a problem hiding this comment.
seems like the Javadoc here is incomplete. Neither of these are sentences.
Contributor
Author
|
R: @dhalperi |
| public final KV<String, Long> close() throws IOException { | ||
| channel.close(); | ||
| KV<String, Long> result = KV.of(fileName, out.getCount()); | ||
| LOG.info("Result for bundle {}: {}, {}", this.id, fileName, result.getValue()); |
Contributor
Author
|
R: @dhalperi |
| * {@inheritDoc} | ||
| * | ||
| * <p> the RPC for at most {@code MAX_RPC_ATTEMPTS} times until it succeeds. | ||
| * <p> Tries executing the RPC for at most {@code MAX_RPC_ATTEMPTS} times until it succeeds. |
added 7 commits
August 3, 2016 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.