[BEAM-6176] Support IPv6 addresses for Flink master url #7196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxm
commented
Dec 4, 2018
| public void shouldSupportIPv6Batch() { | ||
| FlinkPipelineOptions options = PipelineOptionsFactory.as(FlinkPipelineOptions.class); | ||
| options.setRunner(FlinkRunner.class); | ||
| options.setFlinkMaster("host:"); |
Contributor
Author
There was a problem hiding this comment.
I removed this test because HostAndPort permits "host:", in which host will be "host" and port the default port. I think that is fine.
Contributor
Author
angoenka
approved these changes
Dec 8, 2018
Contributor
angoenka
left a comment
angoenka
left a comment
There was a problem hiding this comment.
Thanks Max!
LGTM
Just minor test comments.
| public void shouldSupportIPv6Batch() { | ||
| FlinkPipelineOptions options = PipelineOptionsFactory.as(FlinkPipelineOptions.class); | ||
| options.setRunner(FlinkRunner.class); | ||
| options.setFlinkMaster("host:"); |
runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkExecutionEnvironmentsTest.java
Show resolved
Hide resolved
runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkExecutionEnvironmentsTest.java
Show resolved
Hide resolved
The previous port parsing logic assumed colons to indicate a port number. That assumption clearly can't be made for IPv6 addresses.
Contributor
Author
|
Thanks @angoenka. Added the tests also for Ipv4. |
Contributor
Author
|
Run Python PreCommit |
1 similar comment
Contributor
Author
|
Run Python PreCommit |
Contributor
Author
|
Merging this. Python PreCommit failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous port parsing logic assumed colons to indicate a port number. That
assumption clearly can't be made for IPv6 addresses.
CC @angoenka @tweise
Post-Commit Tests Status (on master branch)