[BEAM-6138] Add a MonitoringInfoSpec proto and SimpleMonitoringInfoBuilder to pro… #7244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vide specs and validate MonitoringInfos are properly populated.
Author
Author
|
Run Python PreCommit |
Author
Ardagan
approved these changes
Dec 11, 2018
| } | ||
|
|
||
| /** Sets the PTRANSFORM MonitoringInfo label to the given param. */ | ||
| public void setPTransformLabel(String pTransform) { |
Contributor
There was a problem hiding this comment.
I think that we can remove setPTransformLabel and setPCollectionLabel and utilize setLabel method inline. We can keep these for convenience as of now.
Author
There was a problem hiding this comment.
I'd like to keep these here for convenience. Plus, using this is preferred since it will prevent missetting the label key.
Author
|
Not sure why this python pipeline is failing, as this PR doesn't touch python code. Perhaps there is an ongoing error? |
Author
|
Run Python PreCommit |
Contributor
|
@ajamato is there a JIRA you can associate with this PR for context? |
Contributor
|
I merged in master to resolve merge conflicts; will merge this PR once pre-commit checks complete. |
swegner
force-pushed
the
simple_monitoring_info_builder
branch
from
5cf1ee7 to
11513c3
Compare
ajamato
changed the title
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vide specs and validate MonitoringInfos are properly populated.
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)