[BEAM-6253] SamzaRunner: Add a few customized transforms for runner use cases#7302
Merged
xinyuiscool merged 1 commit intoapache:masterfrom Dec 18, 2018
Merged
[BEAM-6253] SamzaRunner: Add a few customized transforms for runner use cases#7302xinyuiscool merged 1 commit intoapache:masterfrom
xinyuiscool merged 1 commit intoapache:masterfrom
Conversation
…se cases Support GroupByKey/CoGroupByKey without repartitioning and updating accumulation after firing a window pane.
xinyuiscool
force-pushed
the
BEAM-6253
branch
from
42eead7 to
473e5a6
Compare
lhaiesp
approved these changes
Dec 17, 2018
Contributor
lhaiesp
left a comment
lhaiesp
left a comment
There was a problem hiding this comment.
The change has been reviewed and approved internally at LinkedIn
lhaiesp
reviewed
Dec 17, 2018
|
|
||
| /** | ||
| * A wrapper transform of {@link org.apache.beam.sdk.transforms.GroupByKey} or {@link | ||
| * org.apache.beam.sdk.transforms.join.CoGroupByKey} to indicate there is no repartition needed for |
Contributor
There was a problem hiding this comment.
Maybe a little bit more specific? Like "this is useful when input partitions are already aligned" somewhere in the paragraph.
Contributor
Author
There was a problem hiding this comment.
I am going to address this in a later patch. It's so hard to get beam tests all green :(
Contributor
Author
|
Run Portable_Python PreCommit |
1 similar comment
Contributor
Author
|
Run Portable_Python PreCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support GroupByKey/CoGroupByKey without repartitioning and updating accumulation after firing a window pane.
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)