Skip to content

[BEAM-6179] Fixing iterable comparison #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angoenka merged 2 commits into from
Dec 20, 2018
Merged

[BEAM-6179] Fixing iterable comparison #7313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a51eb3
[BEAM-6179] Fixing itterable comparison
angoenka Dec 19, 2018
d9e318c
Fix whitespace.
robertwb Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sdks/python/apache_beam/transforms/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,11 @@ def linear_regression_no_numpy(xs, ys):
n = float(len(xs))
xbar = sum(xs) / n
ybar = sum(ys) / n
if [xs[0]] * len(xs) == xs:
if xbar == 0:
return ybar, 0
if all(xs[0] == x for x in xs):
# Simply use the mean if all values in xs are same.
return 0, ybar/xbar
return 0, ybar / xbar
b = (sum([(x - xbar) * (y - ybar) for x, y in zip(xs, ys)])
/ sum([(x - xbar)**2 for x in xs]))
a = ybar - b * xbar
Expand All @@ -295,7 +297,7 @@ def linear_regression_numpy(xs, ys):
import numpy as np
from numpy import sum
n = len(xs)
if [xs[0]] * n == xs:
if all(xs[0] == x for x in xs):
# If all values of xs are same then fallback to linear_regression_no_numpy
return _BatchSizeEstimator.linear_regression_no_numpy(xs, ys)
xs = np.asarray(xs, dtype=float)
Expand Down