[BEAM-5315] Python 3 port io.filebased_* modules#7386
Merged
aaltay merged 3 commits intoapache:masterfrom Jan 2, 2019
Merged
Conversation
Contributor
Author
|
This PR is rebased on top of #7358 since it is dependent on those changes. |
RobbeSneyders
force-pushed
the
filebased
branch
from
5fca66a to
8ef6aed
Compare
Contributor
Author
tvalentyn
approved these changes
Jan 2, 2019
tvalentyn
approved these changes
Jan 2, 2019
kanterov
pushed a commit
to kanterov/beam
that referenced
this pull request
Jan 3, 2019
* Add apache_beam.io.filebasedsink_test to Python 3 test suite * Python 3 port filebasedsource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is is part of a series of PRs with goal to make Apache Beam PY3 compatible. The proposal with the outlined approach has been documented here: https://s.apache.org/beam-python-3.
Since the io package is quite big, with a large amount of open issues, I've decided to split up the porting of this package into multiple PRs.
This PR ports the
io.filebasedsource.pymodule and adds the already passingio.filebasedsink_test.pymodule to the Python 3 test suite.Post-Commit Tests Status (on master branch)