[BEAM-6347] Add website page for developing I/O connectors for Java#7397
Merged
melap merged 1 commit intoapache:masterfrom Jan 8, 2019
Merged
[BEAM-6347] Add website page for developing I/O connectors for Java#7397melap merged 1 commit intoapache:masterfrom
melap merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Run Website PreCommit |
melap
force-pushed
the
ioupdates
branch
2 times, most recently
from
fe5ec0a to
cc65b44
Compare
Contributor
Author
melap
commented
Jan 7, 2019
Contributor
Author
melap
left a comment
melap
left a comment
There was a problem hiding this comment.
Addressed all comments, PTAL (particularly the Python page as I removed a lot of Sink stuff)
Contributor
|
Thanks Melissa. This looks great. LGTM other than few comments. Please feel free to merge after addressing these comments. |
chamikaramj
reviewed
Jan 8, 2019
Contributor
Author
|
Thank you for your reviews! I've addressed your comments, and will squash and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new website page for developing I/O connectors for java, moved Python page into same place for consistency, and updated the overview page to intro/point to these two pages.
R: @chamikaramj
Post-Commit Tests Status (on master branch)