Skip to content

[BEAM-6391] fix always true conditions#7430

Merged
chamikaramj merged 1 commit intoapache:masterfrom
ihji:fix_always_true
Jan 14, 2019
Merged

[BEAM-6391] fix always true conditions#7430
chamikaramj merged 1 commit intoapache:masterfrom
ihji:fix_always_true

Conversation

@ihji
Copy link
Contributor

@ihji ihji commented Jan 7, 2019


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

@ihji
Copy link
Contributor Author

ihji commented Jan 7, 2019

R: @chamikaramj

@ihji
Copy link
Contributor Author

ihji commented Jan 7, 2019

run python precommit

@ihji ihji changed the title fix always true conditions [BEAM-6391] fix always true conditions Jan 8, 2019
@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@chamikaramj chamikaramj merged commit fff053b into apache:master Jan 14, 2019
@ihji ihji deleted the fix_always_true branch February 11, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants