Skip to content

[BEAM-6405] Reduce parallelism of PortableValidatesRunner tests#7459

Merged
tweise merged 1 commit intoapache:masterfrom
mxm:BEAM-6405
Jan 10, 2019
Merged

[BEAM-6405] Reduce parallelism of PortableValidatesRunner tests#7459
tweise merged 1 commit intoapache:masterfrom
mxm:BEAM-6405

Conversation

@mxm
Copy link
Contributor

@mxm mxm commented Jan 10, 2019

It looks like the outrageous parallelism, i.e. number of available
cores (e.g. 16), is responsible for the occasional flakiness of the tests on
Jenkins. We should lower the parallelism.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
Build Status --- --- ---

It looks like the outrageous parallelism, i.e. number of available
cores (e.g. 16), is responsible for the occasional flakiness of the tests on
Jenkins. We should lower the parallelism.
@mxm mxm requested a review from tweise January 10, 2019 16:02
@mxm
Copy link
Contributor Author

mxm commented Jan 10, 2019

Run Java Flink PortableValidatesRunner Batch

@mxm
Copy link
Contributor Author

mxm commented Jan 10, 2019

@tweise This together with #7453 should give us consistent green light on PVR.

testClasspathConfiguration: configurations.validatesPortableRunner,
parallelism: 2,
pipelineOpts: streaming ? ["--streaming"] : [],
numParallelTests: 2,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also experiment with this if the flakiness persists.

@mxm
Copy link
Contributor Author

mxm commented Jan 10, 2019

Run Website PreCommit

@tweise tweise merged commit 14426af into apache:master Jan 10, 2019
@tweise
Copy link
Contributor

tweise commented Jan 10, 2019

Nice! We had the same issue with the Python VR tests some time ago; this should cut down resource consumption significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants