Deflake statesampler_test #7492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvalentyn
force-pushed
the
deflake_statesampler_test
branch
from
dc0f0d4 to
0912d52
Compare
…last 1 second, retry once on failure to reduce flakiness
tvalentyn
force-pushed
the
deflake_statesampler_test
branch
from
0912d52 to
7d15def
Compare
Contributor
Author
aaltay
reviewed
Jan 12, 2019
|
|
||
| # Due to somewhat non-deterministic nature of state sampling and sleep, | ||
| # this test is flaky when state duraiton is low. | ||
| # Since increasing state duration significantly would als slow down |
| # this test is flaky when state duraiton is low. | ||
| # Since increasing state duration significantly would als slow down | ||
| # the test suite, we are retrying once on failure as a mitigation. | ||
| @retry(reraise=True, stop=stop_after_attempt(2)) |
Member
There was a problem hiding this comment.
Does this try a total of 2 or 3 times? I recommend 3 if that is not the case already.
Contributor
Author
There was a problem hiding this comment.
This gives the test two attempts total to pass. Originally, I intentionally set a low amount of retries, in case there is some issue we may want to catch, related to original purpose of this test. Increasing to 3.
aaltay
approved these changes
Jan 12, 2019
Member
aaltay
left a comment
aaltay
left a comment
There was a problem hiding this comment.
I can merge after tests pass. Thank you!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)