[BEAM-6452] Fix NullPointerException caused by nested collections#7536
Merged
reuvenlax merged 3 commits intoapache:masterfrom Jan 17, 2019
Merged
Conversation
Member
|
Run Java_Examples_Dataflow PreCommit |
Contributor
Author
|
The examples are failing because the beam1 Jenkins executor is hosed. |
Contributor
Author
|
Run Java_Examples_Dataflow PreCommit |
apilloud
approved these changes
Jan 16, 2019
Member
apilloud
left a comment
apilloud
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding tests!
| .build(); | ||
| } | ||
| } | ||
| } No newline at end of file |
Member
|
Run Java_Examples_Dataflow PreCommit |
1 similar comment
Contributor
Author
|
Run Java_Examples_Dataflow PreCommit |
Member
|
I checked the code, it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A schema of the form List<List> causes a NullPointerException when converting to a POJO. This is because the Java type information was not properly passed down recursively.
R: @kanterov