Skip to content

Conversation

@markflyhigh
Copy link
Contributor

@markflyhigh markflyhigh commented Jan 25, 2019

We added an exclusion in py3 lint since it complains docstring in newly upgraded bigquery_v2_message.py. Add r to make docstring a raw string can fix the issue and make py3 lint happy.

+R: @pabloem


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@pabloem
Copy link
Member

pabloem commented Jan 25, 2019

Thank you Mark! I'll merge once precommits pass

@pabloem
Copy link
Member

pabloem commented Jan 25, 2019

Run Portable_Python PreCommit

@pabloem pabloem changed the title Fix py3 lint error on docstring [BEAM-6487] Fix py3 lint error on docstring Jan 25, 2019
@pabloem pabloem merged commit 198a630 into apache:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants