Skip to content

[BEAM-6165] FlinkMetricContainer cleanup #7637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tweise merged 3 commits into from
Jan 28, 2019
Merged

[BEAM-6165] FlinkMetricContainer cleanup #7637

tweise merged 3 commits into from
Jan 28, 2019

Conversation

@ryan-williams
Copy link
Contributor

@ryan-williams ryan-williams commented Jan 26, 2019

A few minor follow-ons from #7183/#7408:

  • add javadocs
  • move a non-Flink-specific helper to runners/core
  • remove protobuf-package qualifier from some types

R: @mxm

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status		 --- --- --- ---

@ryan-williams ryan-williams mentioned this pull request Jan 28, 2019
Closed
@tweise tweise merged commit e626750 into apache:master Jan 28, 2019
@ryan-williams ryan-williams deleted the fmc-cleanup branch January 28, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tweise tweise tweise approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryan-williams @tweise