Skip to content

Conversation

@markflyhigh
Copy link
Contributor

@markflyhigh markflyhigh commented Jan 28, 2019

This is an integration test that runs a simple version of wordcount pipeline and verifies output file content in Python 3.

Due to BEAM-6158, the test disables save_main_sessions flag. Since it duplicates from the existing wordcout example's behavior, we don't need to run it in existing Python 2 suite. Create Py3IT tag for integration tests that's available in Python 3.

Tests are done by running this test using DataflowRunner in Python 3.5.

@tvalentyn @aaltay @RobbeSneyders


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@markflyhigh
Copy link
Contributor Author

Run Python PreCommit

@markflyhigh
Copy link
Contributor Author

Ready for review. @tvalentyn @aaltay

@tvalentyn
Copy link
Contributor

Thanks, @markflyhigh. I support adding a wordcount test that does not require a main session for the purposes of improving existing Python 3 coverage. However I'd like us to have a better understanding whether we want to keep this test after BEAM-6158 is fixed. Possible reason to keep: in the future we may have another feature for which we will be adding test coverage gradually, and for which --save_main_session will not work out of the box. Reason not to keep - this test is a subset of regular wordcount test.

@markflyhigh
Copy link
Contributor Author

I would prefer to merge this test with test_wordcount_it once BEAM-6158 is fixed but for now, let's keep it in wordcount_it_test.py.

@markflyhigh
Copy link
Contributor Author

@tvalentyn PTAL

@tvalentyn
Copy link
Contributor

Thank you!

@aaltay aaltay merged commit e1ee71a into apache:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants