[BEAM-5303] Adding Python VR tests for Java Reference Runner.#7768
Merged
swegner merged 1 commit intoapache:masterfrom Feb 7, 2019
Merged
[BEAM-5303] Adding Python VR tests for Java Reference Runner.#7768swegner merged 1 commit intoapache:masterfrom
swegner merged 1 commit intoapache:masterfrom
Conversation
Adding a gradle target and a test class for running ValidatesRunner tests with the Java Reference Runner. Also had to add a dependency to base_image_requirements.txt to get it to run properly. Note that this was also causing an error when running Flink's VR tests with Docker.
Contributor
Author
|
Robert, in addition to a regular review, can you confirm whether it's ok to add tenacity to the Docker container? It fails when trying to run tests from fn_api_runner_test otherwise, but I'm not sure if it's appropriate to add it to all built Docker containers if it's only needed for a single test. |
Contributor
Author
|
Run Python PreCommit |
Contributor
Author
|
Run Python Precommit |
Contributor
|
Yes, it's fine to add this to the docker container. |
robertwb
approved these changes
Feb 7, 2019
sdks/python/apache_beam/runners/portability/java_reference_runner_test.py
Show resolved
Hide resolved
Contributor
Author
|
@swegner for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a gradle target and a test class for running ValidatesRunner
tests with the Java Reference Runner. Also had to add a dependency to
base_image_requirements.txt to get it to run properly. Note that this
was also causing an error when running Flink's VR tests with Docker.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)