[BEAM-6623] Exercise ValidatesRunner batch tests in Python 3#7825
Merged
aaltay merged 1 commit intoapache:masterfrom Feb 13, 2019
Merged
[BEAM-6623] Exercise ValidatesRunner batch tests in Python 3#7825aaltay merged 1 commit intoapache:masterfrom
aaltay merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Run Python3 PostCommit |
Contributor
Author
|
+R: @tvalentyn @charlesccychen @aaltay ValidatesRunner tests passed in (on Jenkins this time): https://builds.apache.org/job/beam_PostCommit_Python3_Verify_PR/1/ |
Contributor
Author
|
Run Java PreCommit |
markflyhigh
changed the title
Contributor
|
Run Python Dataflow ValidatesRunner |
Contributor
Author
|
A java unit test failed Java Precommit, but definitely unrelated to this PR since changes are only in Gradle scripts and doesn't touch any Java code. Do I need to rebase? |
Contributor
|
Run Java PreCommit |
tvalentyn
approved these changes
Feb 13, 2019
aaltay
approved these changes
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
validatesRunnerBatchTeststo:beam-sdks-python-test-suites-dataflow-py3so that it runs inbeam_PostCommit_Python3_Verify.All tests passed: https://scans.gradle.com/s/e6akmmigs7524
Two minor changes:
sdistfor DirectRunner tests since this is not required in DirectRunner.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)