[BEAM-6504]Connect SideInputHandler in dataflow runner (Part 2) #7926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuangLED
changed the title
HuangLED
changed the title
Contributor
Author
Contributor
Author
|
ping... |
boyuanzz
reviewed
Mar 4, 2019
| */ | ||
| public class CreateExecutableStageNodeFunction | ||
| implements Function<MutableNetwork<Node, Edge>, Node> { | ||
| private static final Logger LOG = |
Contributor
There was a problem hiding this comment.
is this LOG used somewhere?
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this. Removed.
boyuanzz
approved these changes
Mar 4, 2019
Contributor
boyuanzz
left a comment
boyuanzz
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding these.
Contributor
Author
|
Run Portable_Python PreCommit |
Contributor
Author
|
Run Python_PVR_Flink PreCommit |
Contributor
Author
|
Run Java PreCommit |
3 similar comments
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
lukecwik
approved these changes
Mar 12, 2019
RobbeSneyders
pushed a commit
to RobbeSneyders/beam
that referenced
this pull request
Apr 9, 2019
…che#7926) * Connect SideInputHandler in dataflow runner. * Remove unused LOG info * Remove redundant `include` line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire SideInputHandler (PR#7619) inside dataflow java runner harness.
28 out of 28 validationTest passed in ViewTest.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.