[BEAM-6081]: Create "Dataflow Reaper" infrastructure to periodically clean up stuck Dataflow jobs #7985
Conversation
…clean up stuck Dataflow jobs
|
R: @pabloem |
|
Run Seed Job |
pabloem
left a comment
pabloem
left a comment
There was a problem hiding this comment.
LGTM. Just had a couple questions.
| if err != nil { | ||
| log.Fatalf("Error creating dataflow client, %v", err) | ||
| } | ||
| err = cleanDataflowJobs(client, "apache-beam-testing", 12.0) |
There was a problem hiding this comment.
I'd be more aggressive to mark something as stale. Maybe even 3 or 4 hours? WDYT?
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
It seems that these tests don't get triggered continuously? Does it make sense to run tool tests continuously? This could be part of a different PR I guess. Just wondering.
There was a problem hiding this comment.
Added it to the same jenkins job that cancels.
|
Run Seed Job |
|
Run Seed Job |
|
Run Cancel Stale Dataflow Jobs |
1 similar comment
|
Run Cancel Stale Dataflow Jobs |
|
Very cool. LMK if I should merge this. |
|
Thanks for running the job. https://builds.apache.org/job/beam_CancelStaleDataflowJobs/2/console succeeded and cancelled jobs in https://console.cloud.google.com/dataflow?project=apache-beam-testing so looks fine to be merged. |
…clean up stuck Dataflow jobs (apache#7985) * [BEAM-6081]: Create "Dataflow Reaper" infrastructure to periodically clean up stuck Dataflow jobs
2 participants
[BEAM-6081]: Create "Dataflow Reaper" infrastructure to periodically clean up stuck Dataflow jobs
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.