Skip to content

[BEAM-6864] Pass JobInfo to PortablePipelineRunner.run#8087

Merged
robertwb merged 1 commit intoapache:masterfrom
ibzib:job-info
Mar 20, 2019
Merged

[BEAM-6864] Pass JobInfo to PortablePipelineRunner.run#8087
robertwb merged 1 commit intoapache:masterfrom
ibzib:job-info

Conversation

@ibzib
Copy link

@ibzib ibzib commented Mar 18, 2019

Require JobInfo in JobInvocation's constructor, then require JobInfo to be passed to PortablePipelineRunner.run.

JobInfo is required by the executable stage, so all portable runners will need to create a JobInfo instance at some point. This PR makes that expectation more explicit. It also prevents the need to pass the job id in two places.

R: @angoenka, @robertwb


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@ibzib ibzib force-pushed the job-info branch 2 times, most recently from dc1ec89 to 7973442 Compare March 19, 2019 01:59
@robertwb robertwb changed the title pass JobInfo to PortablePipelineRunner.run [BEAM-XXXX] Pass JobInfo to PortablePipelineRunner.run Mar 19, 2019
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but could you please add a sentence or two explaining why this is motivated?

Also, associate this with a JIRA tag. JIRA entities don't have to be 1:1 with PRs, so you could have something like a "refactor common portable runner infrastructure for better reuse" one.

@ibzib ibzib changed the title [BEAM-XXXX] Pass JobInfo to PortablePipelineRunner.run [BEAM-6864] Pass JobInfo to PortablePipelineRunner.run Mar 19, 2019
@robertwb robertwb merged commit 3beb96d into apache:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants