Skip to content

Conversation

@davidyan74
Copy link
Contributor

@davidyan74 davidyan74 commented Mar 27, 2019

  1. git clone git@github.com:apache/beam.git requires the user to be logged in, while https://github.com/apache/beam does not.
  2. Spaces in the example link need to be escaped.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

1. git clone git@github.com:apache/beam.git requires the user to be logged in, while https://github.com/apache/beam does not.
2. Spaces in the example link need to be escaped.
@davidyan74
Copy link
Contributor Author

R: @qinyeli

@qinyeli
Copy link
Contributor

qinyeli commented Mar 27, 2019

Thanks, David. I can't merge the PR, though, as I am not a Beam commiter.

R: @pabloem Would you be able to review this?

@pabloem pabloem merged commit cea9c32 into apache:master Mar 27, 2019
@pabloem
Copy link
Member

pabloem commented Mar 27, 2019

Done! Thanks!

@davidyan74 davidyan74 deleted the patch-1 branch March 27, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants