[BEAM-6990] Use CoderTranslation for resolving coders in cross-language configuration#8209
Merged
mxm merged 3 commits intoapache:masterfrom Apr 8, 2019
Merged
[BEAM-6990] Use CoderTranslation for resolving coders in cross-language configuration#8209mxm merged 3 commits intoapache:masterfrom
mxm merged 3 commits intoapache:masterfrom
Conversation
The type arguments are very verbose and do not help the type checking.
…ge configuration This replaces the custom coder URN translation code in ExternalTransformRegistrarLoader with the usual CoderTranslation. This will allow to support all coders available across languages.
Contributor
Author
|
Contributor
Author
|
Retest this please |
1 similar comment
Contributor
Author
|
Retest this please |
Contributor
Author
|
Flaky Cassandra tests in https://builds.apache.org/job/beam_PreCommit_Java_Commit/5141/ |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Python PreCommit |
Contributor
Author
|
Run Portable_Python PreCommit |
Contributor
Author
|
ElasticsearchIO related failures: https://builds.apache.org/job/beam_PreCommit_Java_Commit/5245/ |
Contributor
Author
|
Merging this to continue with https://jira.apache.org/jira/browse/BEAM-7029. Please let me know if you have any comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the custom coder URN translation code in ExternalTransformRegistrarLoader with the usual CoderTranslation. This will allow to support all coders available across languages.
CC @tweise
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.