Remove restrictions for Python 3.7 in Dataflow runner.#8216
Merged
aaltay merged 1 commit intoapache:masterfrom Apr 4, 2019
Merged
Remove restrictions for Python 3.7 in Dataflow runner.#8216aaltay merged 1 commit intoapache:masterfrom
aaltay merged 1 commit intoapache:masterfrom
Conversation
tvalentyn
force-pushed
the
allow_37_dataflow
branch
3 times, most recently
from
1d0fbfb to
60b1933
Compare
tvalentyn
force-pushed
the
allow_37_dataflow
branch
from
60b1933 to
552468e
Compare
Contributor
Author
|
R: @aaltay |
aaltay
reviewed
Apr 4, 2019
| if sys.version_info[0:2] in [(2, 7), (3, 5), (3, 6), (3, 7)]: | ||
| return | ||
|
|
||
| debug_options = pipeline_options.view_as(DebugOptions) |
Member
There was a problem hiding this comment.
Do we still need ignore_py3_minor_version experiment?
Contributor
Author
There was a problem hiding this comment.
It may be helpful to force the SDK to start a Dataflow job on, say, python 3.8 when it becomes available. I don't have a strong opinion whether to keep it or not.
Member
There was a problem hiding this comment.
Let's keep it for now, in case you want to get this PR into the release branch.
Python 3.8, probably we will need to add explicit support by changing this list anyway.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes restrictions in Dataflow runner to launch jobs on Python 3.7. Users will still see a warning: http://go/gh/apache/beam/blob/master/sdks/python/setup.py#L172.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.