Skip to content

Conversation

@lukecwik
Copy link
Member

This cleans up a few places which were missed in #8232


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lukecwik
Copy link
Member Author

R: @aljoscha @tweise

@lukecwik
Copy link
Member Author

CC: @angoenka

@lukecwik lukecwik requested review from aljoscha and tweise April 12, 2019 20:48
@lukecwik lukecwik force-pushed the side_input branch 2 times, most recently from 6f39b66 to 4b34e41 Compare April 15, 2019 18:42
@tweise tweise requested a review from mxm April 15, 2019 19:56
Copy link
Contributor

@angoenka angoenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxm
Copy link
Contributor

mxm commented Apr 16, 2019

Run Go PreCommit

@mxm
Copy link
Contributor

mxm commented Apr 16, 2019

Run Java PreCommit

@mxm
Copy link
Contributor

mxm commented Apr 16, 2019

Run Flink ValidatesRunner

Copy link
Contributor

@mxm mxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@angoenka angoenka merged commit 407be69 into apache:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants