[BEAM-7027] Use same method to find a new local available port in IO tests#8307
Merged
aromanenko-dev merged 4 commits intoapache:masterfrom Apr 18, 2019
Merged
Conversation
iemejia
force-pushed
the
BEAM-7027-io-tests-sync
branch
2 times, most recently
from
fcf8ba9 to
b6c031b
Compare
Contributor
aromanenko-dev
left a comment
aromanenko-dev
left a comment
There was a problem hiding this comment.
Thanks! I have a couple of questions inline
sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
Show resolved
Hide resolved
sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
Outdated
Show resolved
Hide resolved
sdks/java/io/clickhouse/src/test/java/org/apache/beam/sdk/io/clickhouse/AtomicInsertTest.java
Show resolved
Hide resolved
sdks/java/io/clickhouse/src/test/java/org/apache/beam/sdk/io/clickhouse/ClickHouseIOTest.java
Show resolved
Hide resolved
...sticsearch-tests-5/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOIT.java
Show resolved
Hide resolved
...sticsearch-tests-6/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOIT.java
Show resolved
Hide resolved
...a/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
Show resolved
Hide resolved
...a/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
Show resolved
Hide resolved
This was discussed and removed for other IOs in the past, IO tests shall not be annotated as NeedsRunner, ValidatesRunner or other categories.
iemejia
force-pushed
the
BEAM-7027-io-tests-sync
branch
from
b6c031b to
894b8c3
Compare
Member
Author
|
PR Updated, PTAL @aromanenko-dev |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @aromanenko-dev