Skip to content

[BEAM-6732] JdbcIO: added "Write.withResults()"#8310

Merged
jbonofre merged 1 commit intoapache:masterfrom
aromanenko-dev:BEAM-6732-JdbcIO-withResults
Apr 16, 2019
Merged

[BEAM-6732] JdbcIO: added "Write.withResults()"#8310
jbonofre merged 1 commit intoapache:masterfrom
aromanenko-dev:BEAM-6732-JdbcIO-withResults

Conversation

@aromanenko-dev
Copy link
Contributor

  • Added new transform called WriteVoid which supplies PCollection<Void> as output;
  • Moved all implementation of Write transform into WriteVoid;
  • Made all methods of Write to be the wrappers around WriteVoid as internal writing transform, no backwards incompatible changes for public API;
  • Added withResults() to Write which returns WriteVoid transform;
  • Some minor tests refactoring.

R: @iemejia @jbonofre


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@aromanenko-dev aromanenko-dev force-pushed the BEAM-6732-JdbcIO-withResults branch from 454a589 to 78919fd Compare April 15, 2019 16:38
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@jbonofre jbonofre merged commit fe79225 into apache:master Apr 16, 2019
@aromanenko-dev aromanenko-dev changed the title [BEAM-6732] Added "Write.withResults()" [BEAM-6732] JdbcIO: added "Write.withResults()" Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants