[BEAM-6908] Support Python3 performance benchmarks - part 2 #8324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
+R: @udim, |
udim
requested changes
Apr 17, 2019
Member
|
run python postcommit |
udim
approved these changes
Apr 18, 2019
Member
udim
left a comment
udim
left a comment
There was a problem hiding this comment.
LGTM, but please wait for postcommits to be green before merging
Contributor
Author
|
Thank you. postcommit failed consistently for a while and got fixed recently (today?). I'll rebase and rerun them. Would like to merge this PR after Perfkit change merged in master to make the transition status as short as possible. |
Contributor
Author
|
run python postcommit |
Contributor
Author
|
Perfkit corresponding changes are merged in GoogleCloudPlatform/PerfKitBenchmarker@d0ad984. We now can merge this PR after tests pass. |
Contributor
Author
|
Run Java PreCommit |
1 similar comment
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Rebased this PR against master. |
Contributor
Author
|
Run Python_PVR_Flink PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Python3 performance benchmarks - part 2
Keep use of Perfkit performance infrastructure for Python3 benchmarking due to exist integration with Python pipeline and automated metrics publishing. Part 1 changes are on PerfkitBenchmarker in GoogleCloudPlatform/PerfKitBenchmarker@d0ad984
Changes include in this PR:
PythonPerformanceTestConfigurationto make task construction clear and easier to maintain.enablePythonPerformanceTestinBeamModulePluginso that people can enable python performance test in different projects by simply calling this function.sdks/python/test-suites/dataflow/py3run_integration_test.shdue to wrong check order.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.