[BEAM-7109] Do not reconnect logging at termination #8367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
angoenka
force-pushed
the
logging_thread_leak
branch
from
3001378 to
bd7e174
Compare
Contributor
Author
|
cc: @yifanzou |
aaltay
approved these changes
Apr 20, 2019
angoenka
force-pushed
the
logging_thread_leak
branch
from
bd7e174 to
6ab73f0
Compare
angoenka
force-pushed
the
logging_thread_leak
branch
from
6ab73f0 to
7857fa7
Compare
Contributor
Author
|
Run Portable_Python PreCommit |
Contributor
|
Thanks for fixing this, Ankur! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indefinite attempt to reconnect logging client causes SDKHarness to get stuck during termination and eventually cause thread leak as each attempt to reconnect create some threads on GRPC side.
The pr deletes the logging stub before reconnecting so that grpc can clean its state.
The PR also introduces _alive flag which is used to determine if logging client should reconnect on disconnect.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.