Skip to content

Conversation

@youngoli
Copy link
Contributor

I'm creating a package that prints well formatted errors for Beam. In
particular this package differentiates between context and error
messages and allows the top-level error message to be sent any time
in the chain of errors and still be the first error to display.

Note that this only adds the package, I will be converting existing
errors into this package in the future.

Example of an old error:

creating new DoFn in scope root/CountWords: binding fn main.extractWordsFn: binding params [{Value int}] to input string: string is not assignable to int

New error:

string is not assignable to int
Caused by:
    creating new DoFn in scope root/CountWords:
    binding fn main.extractWordsFn:
    binding params [{Value int}] to input string:
string is not assignable to int

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Python Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

I'm creating a package that prints well formatted errors for Beam. In
particular this package differentiates between context and error
messages and allows the top-level error message to be sent any time
in the chain of errors and still be the first error to display.
@youngoli
Copy link
Contributor Author

R: @lostluck

@lostluck
Copy link
Contributor

LGTM
Looking forward for this to be in action!
R: @aaltay Please review and merge.

@aaltay aaltay merged commit de2d929 into apache:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants