Skip to content

[BEAM-6880] Remove deprecated Reference Runner code. #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloem merged 3 commits into from
May 20, 2019
Merged

[BEAM-6880] Remove deprecated Reference Runner code. #8380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3d483c
[BEAM-6880] Remove deprecated Reference Runner code.
youngoli Apr 23, 2019
a38e5ae
[BEAM-6880] Remove Java Reference Runner test code.
youngoli Apr 23, 2019
c1c5b3f
[BEAM-6880] Remove additional mentions of removed code.
youngoli May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions runners/direct-java/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ evaluationDependsOn(":sdks:java:core")
configurations {
needsRunner
validatesRunner
validatesPortableRunner
}

dependencies {
Expand All @@ -70,7 +69,6 @@ dependencies {
shadow library.java.args4j
provided library.java.hamcrest_core
provided library.java.junit
testRuntime project(path: ":sdks:java:harness")
Copy link
Copy Markdown
Member

@lukecwik lukecwik May 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, this was a long time pain point since this was part of the classpath and not an arg to TestPipeline that allowed the portable direct runner to launch the SDK harness as a separate process.

shadowTest project(path: ":sdks:java:core", configuration: "shadowTest")
shadowTest project(path: ":runners:core-java", configuration: "shadowTest")
shadowTest library.java.guava_testlib
Expand All @@ -90,13 +88,6 @@ dependencies {
validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
validatesRunner project(path: project.path, configuration: "shadow")
validatesRunner project(path: project.path, configuration: "shadowTest")
validatesPortableRunner project(path: ":runners:core-construction-java", configuration: "shadowTest")
validatesPortableRunner project(path: ":runners:core-java", configuration: "shadowTest")
validatesPortableRunner project(path: ":runners:java-fn-execution", configuration: "shadowTest")
validatesPortableRunner project(path: ":runners:reference:java", configuration: "shadowTest")
validatesPortableRunner project(path: ":sdks:java:core", configuration: "shadowTest")
validatesPortableRunner project(path: project.path, configuration: "shadow")
validatesPortableRunner project(path: project.path, configuration: "shadowTest")
}

task needsRunnerTests(type: Test) {
Expand Down Expand Up @@ -160,37 +151,3 @@ createJavaExamplesArchetypeValidationTask(type: 'MobileGaming',
gcsBucket: gcsBucket,
bqDataset: bqDataset,
pubsubTopic: pubsubTopic)

createPortableValidatesRunnerTask(
jobServerDriver: "org.apache.beam.runners.direct.portable.job.ReferenceRunnerJobServer",
testClasspathConfiguration: configurations.validatesPortableRunner,
jobServerConfig: "--port=0",
testCategories: {
includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
excludeCategories 'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders'
excludeCategories 'org.apache.beam.sdk.testing.LargeKeys$Above100MB'
excludeCategories 'org.apache.beam.sdk.testing.UsesCrossLanguageTransforms'
excludeCategories 'org.apache.beam.sdk.testing.UsesCustomWindowMerging'
excludeCategories 'org.apache.beam.sdk.testing.UsesDistributionMetrics'
excludeCategories 'org.apache.beam.sdk.testing.UsesFailureMessage'
excludeCategories 'org.apache.beam.sdk.testing.UsesParDoLifecycle'
excludeCategories 'org.apache.beam.sdk.testing.UsesTestStream'
// TODO(BEAM-5452): Support metrics.
excludeCategories 'org.apache.beam.sdk.testing.UsesGaugeMetrics'
excludeCategories 'org.apache.beam.sdk.testing.UsesAttemptedMetrics'
excludeCategories 'org.apache.beam.sdk.testing.UsesCommittedMetrics'
excludeCategories 'org.apache.beam.sdk.testing.UsesCounterMetrics'
// TODO(BEAM-3743): Support SplittableDoFn
excludeCategories 'org.apache.beam.sdk.testing.UsesBoundedSplittableParDo'
excludeCategories 'org.apache.beam.sdk.testing.UsesSplittableParDoWithWindowedSideInputs'
excludeCategories 'org.apache.beam.sdk.testing.UsesUnboundedSplittableParDo'
// TODO(BEAM-2928): Support sideinput.
excludeCategories 'org.apache.beam.sdk.testing.UsesSideInputs'
// TODO(BEAM-2917): Support user state.
excludeCategories 'org.apache.beam.sdk.testing.UsesStatefulParDo'
excludeCategories 'org.apache.beam.sdk.testing.UsesMapState'
excludeCategories 'org.apache.beam.sdk.testing.UsesSetState'
// TODO(BEAM-4680): Support user timers.
excludeCategories 'org.apache.beam.sdk.testing.UsesTimersInParDo'
},
)
47 changes: 0 additions & 47 deletions runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/BundleFactory.java
View file
Open in desktop

This file was deleted.

68 changes: 0 additions & 68 deletions ...main/java/org/apache/beam/runners/direct/portable/BundleFactoryOutputReceiverFactory.java
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions ...rs/direct-java/src/main/java/org/apache/beam/runners/direct/portable/BundleProcessor.java
View file
Open in desktop

This file was deleted.

86 changes: 0 additions & 86 deletions ...rs/direct-java/src/main/java/org/apache/beam/runners/direct/portable/CommittedBundle.java
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions ...rs/direct-java/src/main/java/org/apache/beam/runners/direct/portable/CommittedResult.java
View file
Open in desktop

This file was deleted.

Loading