[BEAM-7170] Fix exception when retrieving ExpansionServer port after closing#8424
Merged
mxm merged 1 commit intoapache:masterfrom Apr 29, 2019
Merged
[BEAM-7170] Fix exception when retrieving ExpansionServer port after closing#8424mxm merged 1 commit intoapache:masterfrom
mxm merged 1 commit intoapache:masterfrom
Conversation
…closing The ExpansionServer can throw the following exception after shutdown because the port getter retrieves the port dynamically from the underlying service: ``` java.lang.IllegalStateException: Already terminated at org.apache.beam.vendor.grpc.v1p13p1.com.google.common.base.Preconditions.checkState(Preconditions.java:444) at org.apache.beam.vendor.grpc.v1p13p1.io.grpc.internal.ServerImpl.getPort(ServerImpl.java:174) at org.apache.beam.runners.core.construction.expansion.ExpansionServer.getPort(ExpansionServer.java:66) ```
Contributor
Author
|
Java PreCommit stuck while collecting results, tests related to this PR are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ExpansionServer can throw the following exception after shutdown because the
port getter retrieves the port dynamically from the underlying service:
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.